[{2} files left] message is wrong when connection breaks
Posted: Sat Mar 06, 2010 3:40 am
Number of files left keep decreasing with every upload retry, even files are not being uploaded.
Steps to reproduce:
1) This is harder to reproduce when a file is split. So turn off chuncking of set chunksize larger than the file size
2) Drop N > 1 files into jBatchUpload
3) Start sending
4) Pull the network cable (or disable the network connection)
5) See the status message, every [retryinterval], number of "files left" keeps decreasing!
--Reason--
in "\src\jfileupload\transfer\client\mdesign\ProgressPanel.java", variable [remaining] is decreased on transferStarted()
--Fix--
Move line:
if ((amount > 0) && (remaining > 0) && (fchunkid == 1)) remaining--;
to transferCompleted()
--Note--
This actually helps with other annoyance, because now number of "files left", is really of those left to upload, not MINUS ONE like it used to!
Steps to reproduce:
1) This is harder to reproduce when a file is split. So turn off chuncking of set chunksize larger than the file size
2) Drop N > 1 files into jBatchUpload
3) Start sending
4) Pull the network cable (or disable the network connection)
5) See the status message, every [retryinterval], number of "files left" keeps decreasing!
--Reason--
in "\src\jfileupload\transfer\client\mdesign\ProgressPanel.java", variable [remaining] is decreased on transferStarted()
--Fix--
Move line:
if ((amount > 0) && (remaining > 0) && (fchunkid == 1)) remaining--;
to transferCompleted()
--Note--
This actually helps with other annoyance, because now number of "files left", is really of those left to upload, not MINUS ONE like it used to!